Skip to content

[SourceKit] 4.0: Accept swift_version in requests and use to set the swift version for interface generation of an ObjC header #9338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented May 5, 2017

master: #9308

rdar://31432960

akyrtzi added 3 commits May 5, 2017 09:58
… version for interface generation of an ObjC header

rdar://31432960
…ck for the swift 4 change without duplicating the test file
@akyrtzi
Copy link
Contributor Author

akyrtzi commented May 5, 2017

@swift-ci Please test

@benlangmuir
Copy link
Contributor

LGTM

@akyrtzi
Copy link
Contributor Author

akyrtzi commented May 5, 2017

Explanation: Enables passing the swift version to use for the request to do interface-generation for an ObjC header
Scope: Only affects interface-generation for ObjC headers
Radar: rdar://31432960
Risk: Very low
Testing: Added regression test

@akyrtzi akyrtzi merged commit 2e05ad7 into swiftlang:swift-4.0-branch May 5, 2017
@akyrtzi akyrtzi deleted the interface-gen-header-swift-version-4.0 branch May 5, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants