[Migrator] Add Swift. prefix to type(of:) expressions in Swift 3
#9348
+94
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Thanks! |
|
Huh! This has no effect on Linux? |
|
@akyrtzi reports that he also saw that an unrelated test wasn't printing the migrated content either, so it sounds like something else is going on. I'll investigate in a separate PR. |
|
Figured out the problem there, will address after this. |
|
@swift-ci Please smoke test |
This changed to be resolved by overload resolution in Swift 4, and so can suddenly be shadowed by similarly named properties and functions that are visible at the expression's location. When in Swift 3 mode, if there is a visible declaration named "type", add the `Swift.` prefix to disambiguate in Swift 4 mode. rdar://problem/31997321
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changed to be resolved by overload resolution in Swift 4, and so
can suddenly be shadowed by similarly named properties and functions
that are visible at the expression's location. When in Swift 3 mode, if
there is a visible declaration named "type", add the
Swift.prefix todisambiguate in Swift 4 mode.
rdar://problem/31997321