[SourceKit] When cursor points to an external argument name in a function-like decl, we should return the information about the function-like decl instead of being empty. rdar://32018814 #9356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-like decl, we should return the information about the function-like decl instead of being empty. rdar://32018814
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
benlangmuir
requested changes
May 5, 2017
| /// \param Name the argument name. | ||
| /// \param StartLoc the source loc of the argument name start. | ||
| /// \param D the function-like decl. | ||
| virtual bool visitExternalArgumentName(Identifier Name, SourceLoc StartLoc, |
There was a problem hiding this comment.
Maybe "visitDeclarationArgumentName" to distinguish it from the call argument case above a bit more?
|
|
||
| // CHECK1: source.lang.swift.decl.function.constructor | ||
| // CHECK2: source.lang.swift.decl.function.method.instance | ||
| // CHECK3: source.lang.swift.decl.function.subscript |
There was a problem hiding this comment.
There is already cursor_label.swift; should this go in that file as well? It would also be good to keep them together to make sure that all the cases are tested with both external an local name. For example, I see that the local name tests don't check the kind of entity, whereas these tests don't check for parent_loc (which presumably should not be on anything here).
|
@swift-ci please smoke test |
nkcsgexi
added a commit
that referenced
this pull request
May 6, 2017
…tion-like decl, we should return the information about the function-like decl instead of being empty. rdar://32018814 (#9356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is revised PR based on @benlangmuir 's comments.