Fix two diagnostics crashers #9366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ambiguity inside of a call with a trailing closure call was going down the code path that would tell you to add an argument label... but the ambiguity might not be with the call that has the trailing closure itself, and instead something inside.
CSGen can see an AssignExpr where the destination has an unresolved type, even in a case where no diagnostic has been emitted yet. It is then wrong to return an empty type from here, because this stops us from attempting to solve the expression, which results in no diagnostic being emitted in the end. The test case I added produces a decent diagnostic now, but the original one in the radar now just says 'ambiguous without more context'. Still, better than crashing. Fixes <rdar://problem/30685195>.
slavapestov
force-pushed
the
fix-two-diagnostics-crashers
branch
from
e8a7266 to
427bb32
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/30685195 and what appears to be an unrelated problem with trailing closures that I stumbled upon while reducing the original test case.