[Migrator] Separate AST Pass implementations #9368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SyntacticMigratorPass is getting Too Big To Fail and covers multiple migrations. There was already an early exit to not run the pass if APIDigesterDataStorePath wasn't supplied, so SE-0110 tuple splat fix-its weren't getting run. This manifested in Migrator tests not printing migrated contents on Linux. New: ASTMigratorPass Renamed: SyntacticMigratorPass -> APIDiffMigratorPass New: TupleSplatMigratorPass These implementations are entirely hidden and can only be invoked by a swift::migrator function. rdar://problem/32025974
|
@swift-ci Please test |
|
LGTM |
bitjammer
deleted the
rdar-32025974-separate-migrator-passes-swift-4.0-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SyntacticMigratorPass is getting Too Big To Fail and covers
multiple migrations. There was already an early exit to not run
the pass if APIDigesterDataStorePath wasn't supplied, so SE-0110
tuple splat fix-its weren't getting run. This manifested in Migrator
tests not printing migrated contents on Linux.
New: ASTMigratorPass
Renamed: SyntacticMigratorPass -> APIDiffMigratorPass
New: TupleSplatMigratorPass
These implementations are entirely hidden and can only be invoked
by a swift::migrator function.
rdar://problem/32025974