Fix nested types in closure context and non-static operator crash #9377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tocol or extension that's nested in another type When performing a name lookup from inside of a protocol or extension, skip directly to the source file context when we are done visiting the protocol or extension. Otherwise, if we have invalid code where the protocol or extension is nested inside another type, we might find a member whose type contains generic parameters of the outer type; these parameters will not resolve, since we do not model protocols or extensions nested inside generic contexts (yet?). This supercedes an earlier workaround for a similar issue; the new workaround fixes more crashes. This is needed to avoid crasher regressions with an upcoming patch.
Fixes <rdar://problem/31803589>.
We were not enforcing that operators were static if the operator was defined in a final class, or if it was defined in a non-final class but the operator was itself final. Fixes <rdar://problem/31469036>.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/31104529