Merge pull request #9393 from shajrawi/arg_param_mismatch #9399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/32027045
cherry-pick of PR #9393 into Swift 4.0 branch
• Explanation: Fixes an issue in the large loadable types module pass: given an inout optional function type argument, for which the function signature has changed, we mistakenly treated it the transformed type as an object type instead of address type
• Scope of Issue: This is a Mandatory pass. Can affect any user of Swift 4.0 if their code contains this pattern.
• Risk: Low
• Reviewed By: Arnold Schwaighofer
• Testing: test case from radar now compile and verify correctly, PR testing on Master branch
• Directions for QE: Compile the test case attached to rdar://problem/32027045 , make sure -sil-verify-all is set for extra testing / sanity check.