runtime: make the objc runtime mangling of AnyObject compatible to the swift 3 mangling #9410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e swift 3 mangling
|
@swift-ci Please smoke test and merge |
This was referenced May 9, 2017
slavapestov
reviewed
May 9, 2017
| assert(node->getKind() == Node::Kind::ProtocolList); | ||
| assert(node->getNumChildren() == 1); | ||
| auto typeList = node->begin()[0]; | ||
| assert(typeList->getKind() == Node::Kind::TypeList); | ||
| for (auto &child : *typeList) { | ||
| mangleProtocolWithoutPrefix(child); | ||
| } | ||
| if (additionalProto) { | ||
| mangleProtocolWithoutPrefix(additionalProto); |
There was a problem hiding this comment.
There's one more nitpick. If you have P & AnyObject for some protocol P, then in Swift 3, it will mangle as either P & AnyObject or AnyObject & P, depending on how ProtocolType::canonicalizeProtocols() ordered AnyObject vs P. :-)
There was a problem hiding this comment.
Let's file a radar for this. I think it's not that important for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.