[4.0] SILGen: The foreign-to-native thunk for an @objc protocol member should use a native convention. #9445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@slavapestov This look OK for the 4.0 branch? |
jckarter
changed the title
jckarter
force-pushed
the
objc-protocol-foreign-to-native-thunk-4.0
branch
from
929255f to
e5cd262
Compare
…ld use a native convention. Fixes rdar://problem/31922123.
|
@swift-ci Please test |
jckarter
force-pushed
the
objc-protocol-foreign-to-native-thunk-4.0
branch
from
e5cd262 to
3fdf0b2
Compare
|
@swift-ci Please test |
|
LGTM! |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Referencing an ObjC protocol member as a function value would cause a miscompile due to mishandling of the thunk mapping the method to the Swift function value convention.
Scope: Anyone trying to use ObjC protocol members as function values would experience compiler crashes.
Issue: rdar://problem/31922123
Risk: Low.
Testing: Swift CI, test cases from Radar