Sema: Fix another SE-0110 issue #9454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
The formal type of methods should be (Type) -> (Args...) -> (), not Type -> (Args...) -> (). This only matters in Swift 4 mode, where it was preventing the newly-added test case from type checking. Fixes <rdar://problem/31725325>.
slavapestov
force-pushed
the
se-0110-strikes-again
branch
from
2f54ee8 to
f7bf7ac
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
huonw
added a commit
to huonw/swift
that referenced
this pull request
Jun 14, 2017
Method types are now required to be `(Self) -> (Args...) -> Return`, not `Self -> (Args...) -> Return`. See also swiftlang#9454 . Fixes rdar://problem/32588152 .
huonw
added a commit
to huonw/swift
that referenced
this pull request
Jun 14, 2017
Method types are now required to be `(Self) -> (Args...) -> Return`, not `Self -> (Args...) -> Return`. See also swiftlang#9454 . Fixes rdar://problem/32588152 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formal type of methods should be (Type) -> (Args...) -> (),
not Type -> (Args...) -> ().
This only matters in Swift 4 mode, where it was preventing the
newly-added test case from type checking.
Fixes rdar://problem/31725325.