[4.0] Treat irrefutable casts as irrefutable patterns. #9469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining whether one constructor pattern is a subspace of another, we only checked if the right-hand subspace was larger than the left. If the left is larger than the right then we can short-circuit the comparison once more because it cannot be a subspace. This also takes care of refutable casts in patterns tripping the duplicate case warning.
|
@swift-ci test |
|
@jrose-apple mind one more review for 4.0? |
|
Looks good to me, but at this point a manager should probably look at it too. |
jrose-apple
requested review from
tkremenek and
ematejska
and removed request for
jrose-apple
|
@swift-ci test source compatibility |
|
Unexpected pass by Sourcery? // @lplarson |
|
@swift-ci test source compatibility |
|
I'm reviewing the expected failures. |
|
@swift-ci test source compatibility |
|
There we go. Over to you @tkremenek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Treat irrefutable casts as irrefutable patterns
Scope: Limited. Silences what were spurious warnings.
Radar/SR: Reported
Risk: Low
Testing: Regression tests included in patch
This is a cherry-pick of #9449 and #9464.