[Type checker] Provide actual ObjC runtime name in @NSKeyedArchiveLegacy Fix-Its. #9473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
jrose-apple
reviewed
May 10, 2017
lib/Sema/TypeCheckProtocol.cpp
Outdated
| @@ -6048,13 +6049,16 @@ void TypeChecker::checkConformancesInContext(DeclContext *dc, | |||
| auto insertionLoc = | |||
| classDecl->getAttributeInsertionLoc(/*forModifier=*/false); | |||
| if (isFixable) { | |||
| Mangle::ASTMangler mangler; | |||
There was a problem hiding this comment.
Can you leave behind a comment noting that this is deliberately using the Swift 3 mangling?
jrose-apple
approved these changes
May 10, 2017
There was a problem hiding this comment.
Thanks, Doug!
Erik and I also noticed another inconsistency, which is that we shouldn't be doing any of this on Linux Foundation. (Neither the fix-its nor the eager initialization will work, right?) But at least no one will be using it there, because that already fails to handle non-simple mangled names.
|
yeah, got it #9487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While here, ban users from ever uttering
@ _staticInitializeObjCMetadata.Fixes rdar://problem/32118614.