Skip to content

[4.0] Provide Swift 3 compatible Dict.keys/values #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2017
Merged

[4.0] Provide Swift 3 compatible Dict.keys/values #9475

merged 1 commit into from
May 11, 2017

Conversation

natecook1000
Copy link
Member

This is a cherry pick of #9462.

  • Explanation: Provides backwards-compatibility for the keys and values properties of a dictionary, which have new types in Swift 4.
  • Scope: This adds back the current versions of two properties and marks the new versions as introduced in Swift 4.
  • Radar/SR: rdar://problem/32014786
  • Risk: Low
  • Testing: This adds new validation tests to verify the types in Swift 3 mode; the types were manually tested in Swift 4 mode.

@natecook1000
Merge pull request swiftlang#9462 from natecook1000/nc-dict-keys-compat
dbe2b2d 
[stdlib] Provide Swift 3 compatible Dict.keys/values
@natecook1000 natecook1000 changed the title [stdlib] Provide Swift 3 compatible Dict.keys/values (#9462) [stdlib] Provide Swift 3 compatible Dict.keys/values May 10, 2017
@natecook1000 natecook1000 changed the title [stdlib] Provide Swift 3 compatible Dict.keys/values [4.0] Provide Swift 3 compatible Dict.keys/values May 10, 2017
@natecook1000
Copy link
Member Author

@swift-ci Please test

@airspeedswift airspeedswift self-assigned this May 10, 2017
@airspeedswift airspeedswift merged commit d92a8a9 into swiftlang:swift-4.0-branch May 11, 2017
@natecook1000 natecook1000 deleted the nc-4-dict branch October 4, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@airspeedswift airspeedswift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natecook1000 @airspeedswift