Skip to content

[Exclusivity] Check that accesses are well-formed during diagnostics. #9514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2017
Merged

Conversation

atrick
Copy link
Contributor

@atrick atrick commented May 11, 2017

This can help catch assumptions in current implementation during testing.
It does not need to be merged to 4.0.

This can help catch assumptions in current implementation during testing.
It does not need to be merged to 4.0.
@atrick atrick requested a review from devincoughlin May 11, 2017 21:21
@atrick
Copy link
Contributor Author

atrick commented May 11, 2017

@swift-ci test.

Copy link
Contributor

@devincoughlin devincoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

Do we already have a test that would fail without the PointerToAddressInst case? I don't think I wrote one explicitly.

@atrick
Copy link
Contributor Author

atrick commented May 11, 2017

@devincoughlin test added to this PR (to avoid killing/losing the CI):
#9520

@swift-ci swift-ci merged commit f78a2ab into swiftlang:master May 12, 2017
@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - f78a2ab
Test requested by - @atrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants