Minor adjustments to stats-output-dir and supporting script #9522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Can we fix our YAML output to properly escape when necessary? This looks good as a stopgap, at least. |
jckarter
approved these changes
May 11, 2017
|
@jckarter Sadly the YAML non-quotable restriction is in libLLVMSupport, and the whole subsystem responsible for it is scheduled for significant reorganization (as soon as they can agree on how). I'm just doing bandaids at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just makes stats-output-dir a bit less likely to crash on bad filenames in assert builds, and improves the output digestion script (clearer formatting, thresholds, new comparison mode).
None of this is meaningful unless you're doing perf analysis.