[GSB] Performance improvements for +Asserts builds #9529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icEnvironment(). GenericSignature::createGenericEnvironment() is a better API for this.
…fine. Put the archetype anchor consistency checking behind a separate it is really expensive: turning this checking off shaves 5s off the type-checking time of the standard library in my Release+Asserts build (~23% speedup).
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When type-checking the standard library, we were spending a lot of time in one particular assertion in the
GenericSignatureBuilderthat checks for consistent selection of archetype anchors. Disable that assertion unless a new debugging#definenamedSWIFT_GSB_EXPENSIVE_ASSERTIONSis enabled. This shaves 5 seconds off the type-checking time for myRelWithDebInfobuild of the Swift standard library (a 23% speed-up).Part of rdar://problem/32116933