[QoI] Unify member diagnostics into one FailureDiagnosis method #9538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
xedin
force-pushed
the
unify-member-diagnostics
branch
from
89bd37d to
7e9b892
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
/cc @slavapestov @rudkx I think this is ready for initial review. All of the scattered logic for diagnosing inaccessible/unavailable and other member lookup related cases is now in one place and all four related methods (UnresolvedDot, UnresolvedMember, Subscript, and GeneralMemberFailure) use it. |
xedin
changed the title
slavapestov
approved these changes
May 16, 2017
xedin
force-pushed
the
unify-member-diagnostics
branch
2 times, most recently
from
4153aba to
883a2c7
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test OS X platform |
|
@slavapestov Any idea why typo_test started producing |
|
@swift-ci please clean smoke test |
xedin
force-pushed
the
unify-member-diagnostics
branch
from
883a2c7 to
dd9469e
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes aim to unify logic behind member diagnostics
into a single method instead of maintaining different versions
in
visitUnresolvedMemberExpr,visitSubscriptExpr,visitUnresolvedDotExpranddiagnoseGeneralMemberFailure.Since all of aforementioned methods do the same thing, with
minor expression specific differences, it makes sense to put
most of the logic into a single place and provide appropriate
callbacks to implement expression specific logic.