[WIP]migrator: handle function hoist API changes. rdar://31234806 #9544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nathawes
reviewed
May 12, 2017
include/swift/IDE/APIDigesterData.h
Outdated
| StringRef oldPrintedName; | ||
|
|
||
| private: | ||
| DeclNameViewer OldNameViwer; | ||
| DeclNameViewer NewNameViwer; |
nathawes
reviewed
May 12, 2017
| if (auto RI = Item->removedIndex) | ||
| IgnoredArgIndices.push_back(*RI); | ||
| emitRenameLabelChanges(Arg, NewName, IgnoredArgIndices); | ||
| auto *SelfExpr = AllArgs[0].ArgExp; |
There was a problem hiding this comment.
Does this assume SelfIndex is 0? Would an assert be worthwhile?
There was a problem hiding this comment.
good catch, line 370 will return if SelfIndex is not 0. Current transformation mechanism may have limitation to handle non-zero selfindex. Fortunately, we don't see any of them in real frameworks.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.