[4.0] Serialization: Handle possibly-null serialized xrefs for optional protocol witnesses. #9563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrose-apple Mind reviewing for Swift 4.0? |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
jckarter
changed the title
|
Build failed |
…tocol witnesses. Fixes SR-4850 | rdar://problem/32134722.
jckarter
force-pushed
the
optional-protocol-reqt-witness-deserialization-4.0
branch
from
f25bf04 to
efc5c55
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The deserialization code for protocol conformances failed to account for null witness xrefs deserialized to represent an
optionalprotocol requirement with no witness in the conformance.Scope: Any code using
optionalprotocol requirements crashes when deserialized.Issue: SR-4850, rdar://problem/32134722.
Risk: Low, bug fix.
Testing: Swift CI, compatibility suite, tests from radar and Jira