[SR-533] Improve C-style for fixits by also removing 'var' keyword from loop var decl. #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om loop var decl.
|
I did this in a way that left extra whitespace originally, and @jrose-apple suggested the correct solution. Changed to his suggestion, updated tests, committed, squashed, yada. |
lattner
added a commit
that referenced
this pull request
Jan 15, 2016
[SR-533] Improve C-style for fixits by also removing 'var' keyword from loop var decl.
|
Cool, thanks! Please email swift-dev to see if Ted approves pulling this into Swift 2.2. |
|
Cherry-picked into swift-2.2-branch: 2ed463a |
MaxDesiatov
added a commit
to MaxDesiatov/swift
that referenced
this pull request
May 12, 2020
…kflow Remove unused step from main.yml workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I missed this part originally! You’d get to the correct code eventually because after switching to a for/in the next compile would suggest replacing the ‘var’ with ‘let’ and then the ‘let’ with nothing, but better to save a couple steps.