Fix for nested LoadExprs fix and cleanups #9625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lowering a LoadExpr, SILGen constructs an LValue and loads from it to produce an RValue. If a LoadExpr contains another LoadExpr, the innermost LoadExpr builds its own LValue, which is then loaded to an RValue, and turned back into an LValue by creating a single ValueComponent. When evaluating an OpenExistentialExpr inside an LValue, we record the base expression and evaluate it as an LValue later when we encounter the corresponding OpaqueValueExpr. The problem is when this is combined with a nested LoadExpr, we might be inside of a different LValue than the original LValue that contained the OpenExistentialExpr. This would trigger an assertion, because the mapping from OpaqueValueExprs to their base expressions was per-LValue; instead, it needs to be per-SILGenFunction.
We should not touch 'this' after a 'std::move(this)'.
This component should only be used if the base is an opaque existential value; otherwise SIL has no way to express a projection of the payload.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.