Skip to content

[Foundation] Correct symbolic availability for CFURL component characer set accessors #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

phausler
Copy link
Contributor

This resolves rdar://problem/32188090
tvOS 9.0 did not have the symbols for the CFURLComponents accessor methods for character sets; this change works around that to use the Foundation variants via shim functions

@phausler
Copy link
Contributor Author

@swift-ci please test

@phausler phausler requested a review from parkera May 15, 2017 23:05
@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - f077698
Test requested by - @phausler

@phausler
Copy link
Contributor Author

/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/test/Constraints/disjunction_ordering_failures.swift:8:11: error: unexpected error produced: use of undeclared type 'CGFloat'
17:22:47 extension CGFloat: P { }
17:22:47           ^
17:22:47 /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/test/Constraints/disjunction_ordering_failures.swift:11:10: error: unexpected error produced: use of undeclared type 'CGFloat'
17:22:47   let h: CGFloat = 0

Pretty certain CharacterSet should not have interaction with CGFloat

@phausler
Copy link
Contributor Author

@swift-ci please test

@phausler phausler merged commit caf5f68 into swiftlang:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants