Skip to content

[stdlib] Reverting the String.init?(_: String) behavior #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented May 16, 2017

One cannot simply change the default behavior of String.init(_: String), because:

let blah = String("hello")
return blah!

rdar://problem/32146774

@moiseev
Copy link
Contributor Author

moiseev commented May 16, 2017

@swift-ci Please Test Source Compatibility

@moiseev
Copy link
Contributor Author

moiseev commented May 16, 2017

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - a4b7f37
Test requested by - @moiseev

@moiseev
Copy link
Contributor Author

moiseev commented May 16, 2017

@swift-ci Please smoke test macOS platform

1 similar comment
@moiseev
Copy link
Contributor Author

moiseev commented May 17, 2017

@swift-ci Please smoke test macOS platform

@moiseev
Copy link
Contributor Author

moiseev commented May 17, 2017

@swift-ci Please Test Source Compatibility

@moiseev moiseev merged commit 8876655 into swiftlang:master May 17, 2017
@moiseev moiseev deleted the hate-string-init branch May 17, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants