Skip to content

[stdlib] SignedNumber to refine Comparable in Swift 3 mode #9669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2017
Merged

[stdlib] SignedNumber to refine Comparable in Swift 3 mode #9669

merged 1 commit into from
May 17, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented May 16, 2017

Fixes: https://bugs.swift.org/browse/SR-4899

  • Explanation: SignedNumber protocol used to refine Comparable in Swift 3
  • Scope of Issue: When I introduced the SignedNumber type alias for source compatibility in Swift 3 mode, the Comparable part was lost. This change introduces it back.
  • Risk: Minimal
  • Reviewed By: Ben Cohen
  • Testing: Automated test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/32235653

@moiseev
Copy link
Contributor Author

moiseev commented May 16, 2017

Similar to #9668

@moiseev
Copy link
Contributor Author

moiseev commented May 16, 2017

@swift-ci Please smoke test

@shahmishal
Copy link
Member

@swift-ci please test

@moiseev moiseev merged commit 3d49842 into swiftlang:swift-4.0-branch May 17, 2017
@moiseev moiseev deleted the signednumber-comparable-4 branch May 17, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moiseev @shahmishal