Runtime: Include source location information in log messages about deprecated implicit Objective-C entry points. #9671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
…precated implicit Objective-C entry points. Make it easier for migration by pinpointing exactly where to insert @objc to keep the entry points in Swift 4 mode. rdar://problem/32230003
jckarter
force-pushed
the
implicit-objc-log-source-location
branch
from
d58abf1 to
c8a7a44
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@phausler Does this DateInterval failure look familiar? https://ci.swift.org/job/swift-PR-osx-smoke-test/8234/testReport/junit/Swift(macosx-x86_64)/stdlib/TestDateInterval_swift/ |
|
hmm that is a failure in the JSON coder stuff perhaps @itaiferber might have an idea here: looks like floating point failures? |
|
Yeah, likely some floating-point error. I disabled the failing test in #9682 so this should be clean now. |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
Thanks @itaiferber and @phausler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier for migration by pinpointing exactly where to insert @objc to keep the entry points in Swift 4 mode. rdar://problem/32230003