Skip to content

[Migrator] Allow make_decl_objc diagnostic note into the FixitApplyDi… #9677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2017
Merged

[Migrator] Allow make_decl_objc diagnostic note into the FixitApplyDi… #9677

merged 1 commit into from
May 17, 2017

Conversation

bitjammer
Copy link
Contributor

…agnosticConsumer

This allows the migrator to pick up fix-its from notes such as:

“Argument of #selector refers to instance method '___' that is not
exposed to Objective-C”

Add some more testing for minimal/complete workflows, and upstream
the cross-file fix-it test.

rdar://problem/32228948

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

3 similar comments
@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test OS X

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

@bitjammer
Copy link
Contributor Author

Eh! Forgot to commit some test files.

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

2 similar comments
@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

…sumer

This allows the migrator to pick up fix-its from notes such as:

“Argument of #selector refers to instance method '___' that is not
exposed to Objective-C”

Add some more testing for minimal/complete workflows, and upstream
the cross-file fix-it test.

rdar://problem/32228948
@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test OS X

@bitjammer bitjammer merged commit 65e4ba7 into swiftlang:master May 17, 2017
@bitjammer bitjammer deleted the rdar-32228948-migrator-add-objc-note-fixit-filter branch May 17, 2017 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants