-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Migrator] Allow make_decl_objc diagnostic note into the FixitApplyDi… #9677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bitjammer
merged 1 commit into
swiftlang:master
from
bitjammer:rdar-32228948-migrator-add-objc-note-fixit-filter
May 17, 2017
Merged
[Migrator] Allow make_decl_objc diagnostic note into the FixitApplyDi… #9677
bitjammer
merged 1 commit into
swiftlang:master
from
bitjammer:rdar-32228948-migrator-add-objc-note-fixit-filter
May 17, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci Please smoke test |
3 similar comments
@swift-ci Please smoke test |
@swift-ci Please smoke test |
@swift-ci Please smoke test |
@swift-ci Please smoke test OS X |
@swift-ci Please smoke test |
akyrtzi
approved these changes
May 17, 2017
Eh! Forgot to commit some test files. |
@swift-ci Please smoke test |
…sumer This allows the migrator to pick up fix-its from notes such as: “Argument of #selector refers to instance method '___' that is not exposed to Objective-C” Add some more testing for minimal/complete workflows, and upstream the cross-file fix-it test. rdar://problem/32228948
@swift-ci Please smoke test |
@swift-ci Please smoke test OS X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…agnosticConsumer
This allows the migrator to pick up fix-its from notes such as:
“Argument of #selector refers to instance method '___' that is not
exposed to Objective-C”
Add some more testing for minimal/complete workflows, and upstream
the cross-file fix-it test.
rdar://problem/32228948