[StdLib] Refactor DictionaryKeyValueTypes test input data #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2016
|
This change splits |
|
Thanks. I've updated the PR with those calls. |
|
Can one of the admins verify this patch? |
|
@swift-ci Please test |
|
The linux test here failed because of a check out failure (not sure why). Rerunning the linux platform. @swift-ci Please test Linux Platform |
|
@ezephir Can you update the PR so it merges cleanly and we can retest it? Thanks. |
Split the input file into a pure Swift and Objective-C interop files in anticipation of refactoring tests to remove XFAILs on Linux.
|
@dabrahams Updated! Thanks. |
|
@swift-ci Please test |
|
Passes tests... Merging. |
gottesmm
added a commit
that referenced
this pull request
Mar 5, 2016
[StdLib] Refactor DictionaryKeyValueTypes test input data
|
@dabrahams Did you review? |
|
@gribozavr Sorry if that was premature. I can revert if/when you want me to. |
|
I reviewed it, LGTM. |
kateinoigakukun
pushed a commit
to kateinoigakukun/swift
that referenced
this pull request
Sep 7, 2020
…-nightly Update BASE_URL in install-nightly-toolchain.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the input file into a pure Swift and Objective-C interop files in
anticipation of refactoring tests to remove XFAILs on Linux.
Tested on OS X 10.10 and Ubuntu 14.04.