Skip to content

Revert "Add Codable conformance to common Foundation types" #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2017

Conversation

milseman
Copy link
Member

@milseman milseman commented May 17, 2017

This reverts commit dee889f.

@milseman
Copy link
Member Author

@itaiferber this is reverting your commit from yesterday, which broke 32bit iPhone simulator tests. Could you re-open that PR (#9632) and do full OS X testing rather than just smoke?

@milseman
Copy link
Member Author

@swift-ci please test

@milseman milseman requested a review from itaiferber May 17, 2017 18:59
@milseman
Copy link
Member Author

Specifically:

10:48:37 dyld: Library not loaded: libFoundationTestsShared.dylib
10:48:37   Referenced from: /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/swift-macosx-x86_64/test-iphonesimulator-i386/stdlib/Output/TestCalendar.swift.tmp/TestCalendar
10:48:37   Reason: image not found
10:48:37 Child process terminated with signal 6: Abort trap
10:48:37 

@milseman milseman merged commit 49a8cf0 into swiftlang:master May 17, 2017
@milseman
Copy link
Member Author

Merged as all (non-smoke) PR testing and package builders are blocked on this. Will continue to monitor the results as well.

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 75c476b
Test requested by - @milseman

@milseman
Copy link
Member Author

I'm not sure why the builder is taking so long, but the good news is that it seems to be passing.

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 75c476b
Test requested by - @milseman

@milseman milseman deleted the revert_break branch May 18, 2017 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants