Add Codable conformance to common Foundation types #9715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiferber
force-pushed
the
foundation-codable-conformances
branch
from
b17383b to
e3978ff
Compare
|
@swift-ci Please smoke test OS X |
|
Please do a full test on macOS before merging this time. |
|
@jrose-apple Will do. Just want to make sure the tests compile and run here briefly before continuing. |
itaiferber
force-pushed
the
foundation-codable-conformances
branch
3 times, most recently
from
0817a47 to
2b45e18
Compare
|
@swift-ci Please test and merge |
itaiferber
force-pushed
the
foundation-codable-conformances
branch
from
2b45e18 to
aae2d40
Compare
|
@swift-ci Please test and merge |
|
I don't know why GitHub suddenly reported a merge conflict that had to be resolved (because there was nothing really conflicting), but let's try this again... |
|
@swift-ci Please test and merge |
itaiferber
force-pushed
the
foundation-codable-conformances
branch
from
b166501 to
c0ec2c5
Compare
Add conformances + unit tests for * CGFloat * AffineTransform * Calendar * CharacterSet * DateComponents * DateInterval * Decimal * IndexPath * IndexSet * Locale * Measurement * NSRange * PersonNameComponents * TimeZone * URL * UUID along with some unit tests for each.
itaiferber
force-pushed
the
foundation-codable-conformances
branch
from
c0ec2c5 to
012ea93
Compare
|
@swift-ci Please test and merge |
This was referenced Jul 22, 2017
This was referenced May 18, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Take two of this PR because I broke the iOS builders last time.
Add conformances + unit tests for
along with some unit tests for each.