Remove a hack to change linkage from public_external to shared. #9731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linkage change let the compiler generate code for public functions which are imported from the stdlib - and are also available in the swiftCore library. This got worse since we use public linkage for @_versioned internal functions in the stdlib. Getting rid of the linkage change reduces code size a lot: up to 40% for some projects. I didn’t see any significant impact on benchmark performance.
|
@swift-ci Please smoke test and merge |
|
This is safe because we always copy a function before we specialize it, right? |
|
(In the resilient world we won't be able to do this, since the implementation in the stdlib could change.) |
|
Talked with Jordan offline. For now this change is safe. |
|
@eeckstein Should we at least add a TODO or FIXME comment in the source code regarding resilience? |
|
@swiftix I'll file a radar. The things what we have to do are not in the source file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linkage change let the compiler generate code for public functions which are imported from the stdlib - and are also available in the swiftCore library.
This got worse since we use public linkage for @_versioned internal functions in the stdlib.
Getting rid of the linkage change reduces code size a lot: up to 40% for some projects.
I didn’t see any significant impact on benchmark performance.