A few fixes for preCheckExpression(), and a cleanup #9787
Merged
+58
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the left hand side was not a TypeExpr, we would just drop it on the floor instead of giving up on forming a protocol composition.
…s in expression context Generic type specialization is ambiguous with < and > operators. Extend the disambiguation hack to also consider parsing a generic parameter list if the > is followed by &. This fixes parsing types such as 'Base<Int> & P' in expression context.
slavapestov
force-pushed
the
pre-check-expression-preliminaries
branch
2 times, most recently
from
531d520 to
54d709a
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.