SILGen: Use VarDecl::getInterfaceType instead of getType in emitForeignToNativeThunk. #9797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnToNativeThunk. getType() only gets set if the decl is type-checked, and is deprecated moreover. Fixes rdar://problem/32280288.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
Unrelated test failure on Linux: @phausler Would you know who to ping about Linux libdispatch? |
|
@swift-ci Please smoke test Linux |
|
@das or @dgrove-oss might have some insight here (or know the right people to look at it) |
|
I'll look at upping the max latency in the dispatch tests that are time sensitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getType() only gets set if the decl is type-checked, and is deprecated moreover. Fixes rdar://problem/32280288.