[Serialization] Fix incorrect counting of value witnesses #9800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Actually ProtocolConformance::dump when 'this' is a NormalProtocolConformance.) No functionality change.
If any of the witnesses were missing (because the requirement was optional or marked unavailable), we would forget to count it, which led to us dropping or even misinterpreting further witness records. This led to strange crashes down the line when the type checker would expect witness entries to be present when they weren't.
|
@swift-ci Please smoke test |
|
I'm kind of amazed we haven't hit this before. We've been serializing absent witnesses for a while. |
|
Eagerly landing, but would still like a review for the 4.0 branch at #9801. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 20, 2017
…-absent [Serialization] Fix incorrect counting of value witnesses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any of the witnesses were missing (because the requirement was optional or marked unavailable), we would forget to count it, which led to us dropping or even misinterpreting further witness records. This led to strange crashes down the line when the type checker would expect witness entries to be present when they weren't.