Disable diagnostics about problem NSCoding-conforming classes for now. #9808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adoption so far shows that the criteria we set up here are too broad. This is particularly problematic for subclasses of NS/UIView and the like that might never be encoded at all. rdar://problem/32306355
|
@swift-ci Please smoke test |
|
Looks good to me too. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
May 20, 2017
swiftlang#9808) Adoption so far shows that the criteria we set up here are too broad. This is particularly problematic for subclasses of NS/UIView and the like that might never be encoded at all. rdar://problem/32306355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adoption so far shows that the criteria we set up here are too broad. This is particularly problematic for subclasses of NS/UIView and the like that might never be encoded at all.
rdar://problem/32306355