More member reference simplification #9824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually want to open the type; instead, calculate the substituted member type using substMemberTypeWithBase(), which will return an unbound generic type if the member is a generic nominal or type alias, and then it open it with openUnboundGenericType(). This is NFC for now, but I need generic typealiases to come in as UnboundGenericTypes here in a subsequent patch.
Separate out the code paths for different kinds of Decls to make the logic here more apparent.
slavapestov
force-pushed
the
more-member-reference-simplification
branch
from
a799671 to
d5f6abb
Compare
slavapestov
changed the title
…o getTypeOfMemberReference()
We did things with subscripts in two places in this function; move them closer together.
slavapestov
force-pushed
the
more-member-reference-simplification
branch
from
d5f6abb to
73976b2
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.