[GSB] AbstractProtocol requirements are never explicit. #9856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
DougGregor
reviewed
May 23, 2017
|
Aha, that makes sense. |
huonw
force-pushed
the
concrete-types-are-concrete
branch
from
6fec176 to
6f3bb1e
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test. |
|
This is a legitimate timeout. The change now causes the compiler to do the infinite recursion/expansion thing in the standard library. |
huonw
force-pushed
the
concrete-types-are-concrete
branch
from
6f3bb1e to
9ecf87e
Compare
…and not inferred. If they're considered explicit, requirement inference will complain when it infers X: SomeProtocol for some concrete type X. Fixes SR-4693, rdar://problem/31819616
huonw
force-pushed
the
concrete-types-are-concrete
branch
from
9ecf87e to
578097c
Compare
|
@swift-ci Please smoke test and merge. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If they're considered explicit, requirement inference will complain when
it infers X: SomeProtocol for some concrete type X.
Fixes SR-4693, rdar://problem/31819616
I suspect this isn't correct, but the git history didn't reveal the reasoning, I'm not sure I fully grasped the space, and, tests seemed to pass locally.