SILGen: Fix issues with types nested inside fully-concrete extensions #9860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
more-fun-with-constrained-extensions
branch
from
6ada11d to
ec07a4a
Compare
Add a new version of TypeConverter::getEffectiveGenericSignature() which takes a DeclContext, which uses the same logic as the AnyFunctionRef version, and use it when computing lowered types for destructors, stored property initializers and ivar destroyers. Also, canonicalize the interface type of 'Self' as part of building these types, to fold away concrete generic parameters. Fixes <rdar://problem/32120987>.
slavapestov
force-pushed
the
more-fun-with-constrained-extensions
branch
from
ec07a4a to
9c7afa7
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new version of TypeConverter::getEffectiveGenericSignature()
which takes a DeclContext, which uses the same logic as the
AnyFunctionRef version, and use it when computing lowered types
for destructors, stored property initializers and ivar destroyers.
Also, canonicalize the interface type of 'Self' as part of building
these types, to fold away concrete generic parameters.
Fixes rdar://problem/32120987.