Improve TBD validation logic #9884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can now: - not validate (=none) - validate that all symbols in the IR are also in the TBD (=missing), - validate the above, and also that all in the TBD are in the IR (=all). The first and last were switched between with the old boolean flag, the second is new.
SIB files may have "manually" added SIL, in which case the TBD computed from the AST will be missing some symbols: those defined only in the SIL.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restricts the validation of TBD to cases when we know that SIL/IR is entirely computed from AST (from which we compute the list of symbols), rather than situations when, say, compiling IR/SIL directly, or a SIB file which may also include SIL.
Additionally, split -validation-tbd-against-ir to be able allow the TBD to have extra symbols, letting us ensure that we include everything without having to ensure that we don't include extraneous ones (missing symbols is worse than extra symbols).