Skip to content

Minor script tweaks #9912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2017
Merged

Minor script tweaks #9912

merged 2 commits into from
Jun 14, 2017

Conversation

graydon
Copy link
Contributor

@graydon graydon commented May 24, 2017

Just a couple mistakes fixed, found while doing perf work last week.

@graydon graydon requested a review from huonw May 24, 2017 20:38
@graydon
Copy link
Contributor Author

graydon commented May 24, 2017

@swift-ci please smoke test

huonw
huonw reviewed May 24, 2017
View reviewed changes
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what either of these scripts are doing, so can't really say much other than that these changes don't seem wrong.

@graydon graydon force-pushed the minor-script-tweaks branch from 664ee76 to 09b4753 Compare May 25, 2017 16:39
@graydon
Copy link
Contributor Author

graydon commented May 25, 2017

@swift-ci please smoke test and merge

1 similar comment
@graydon
Copy link
Contributor Author

graydon commented Jun 14, 2017

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 4b0597a into swiftlang:master Jun 14, 2017
@graydon graydon deleted the minor-script-tweaks branch September 13, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graydon @huonw @swift-ci