Revert "[stdlib] Add Substring comparison benchmarks"

[shajrawi]

Reverts #9917

Fails to build:
/Users/buildnode/jenkins/workspace/oss-swift-incremental-RA-osx/swift/benchmark/utils/main.swift:233:69: error: use of unresolved identifier 'run_EqualStringSubstringGenericStringProtocol'

[dabrahams]

OMG, you can't just comment out tests; you have to rename them. Bah, humbug.

[palimondo]

@dabrahams Do you want me to mess with the regEx that gathers the test names to ignore those with single line comments?

[palimondo]

@dabrahams But I don't think it's worth it. It could not possibly cover your block comment. And there's the rule about not storing code in comments when we have version control… :-)

[palimondo]

@dabrahams Why did you want to comment them out? Your initial comment on #9917 does not explain this to me. If you just wanted to not have them run as precommit checks, you could just stash them in the "string" test suite by modifying main.swift.gyb to match them in this section:

string_re = [
    "StringWalk.+",
]

Then rerun the harness generation again.

[dabrahams]

on Wed May 24 2017, Pavol Vaskovic <notifications-AT-i.8713187.xyz> wrote:

@dabrahams But I don't think it's worth it. It could not possibly cover your block comment. And there's the rule about not storing code in comments when we have version control… :-)

This code was never checked in, so that doesn't apply.

…

-- -Dave