[stdlib] Renames and tests for Swift 3 compatibility mode #9949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses <rdar://problem/32432481>
|
@swift-ci Please smoke test |
|
@swift-ci Please Test Source Compatibility |
|
@jrose-apple This re-introduces the message from #9949. Does this one look better? |
moiseev
commented
May 26, 2017
|
|
||
| func signedIntegerMaskingArithmetics<T : SignedInteger>(x: T) { | ||
| _ = x &+ x // expected-error {{use 'FixedWidthInteger' instead of 'SignedInteger' to get '&+' in generic code}} | ||
| _ = x &- x // expected-error {{use 'FixedWidthInteger' instead of 'SignedInteger' to get '&-' in generic code}} |
There was a problem hiding this comment.
I don't remember what my original concern was (your link is to this PR, not whatever we talked about before). This looks fine to me now.
There was a problem hiding this comment.
Argh... This is the right one: #9045. The concern was about the message not being very clear.
There was a problem hiding this comment.
Ah, yes, I like the new message a lot better. Thanks, Max!
nkcsgexi
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rdar://problem/32432481