[ConstraintSolver] Skip generic overloads only if non-generic choices produce higher score solutions #9963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
changed the title
|
@swift-ci please smoke test |
|
@rudkx Could you please take a look and let me know if that's a good generic direction for this? There is a test failure related to unmapped generic parameters in the solution in the IDE test, I'll debug that later if you think that this is a viable approach. |
xedin
force-pushed
the
rdar-32204609
branch
2 times, most recently
from
ef0d0f7 to
c224c45
Compare
|
/cc @DougGregor |
DougGregor
approved these changes
Jun 1, 2017
… produce higher score solutions Restrict skipping of the generic overloads only to the situations when non-generic solution doesn't have any restrictions/fixes, because there is a possibility that generic overload could produce a better solution. Resolves: rdar://problem/32204609.
There are possible situations when we find solutions with String and String -> UnsafePointer conversions at the same time for expressions with default string literals. In order to disambiguite such situations let's prefer solutions without String -> UnsafePointer conversions if possible.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict skipping of the generic overloads only to the situations
when non-generic solution doesn't have any restrictions/fixes, because
there is a possibility that generic overload could produce a better
solution.
Resolves: rdar://problem/32204609.