Skip to content

[Debugger] Migration to DeclBaseName in preparation for special decl names #9975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/swift/AST/DebuggerClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,16 @@ class DebuggerClient {
/// be consulted first. Return true if results have been added
/// to RV.
/// FIXME: I don't think this ever does anything useful.
virtual bool lookupOverrides(Identifier Name, DeclContext *DC,
virtual bool lookupOverrides(DeclBaseName Name, DeclContext *DC,
SourceLoc Loc, bool IsTypeLookup,
ResultVector &RV) = 0;

/// This is the second time DebuggerClient is consulted:
/// after all names in external Modules are checked, the client
/// gets a chance to add names to the list of candidates that
/// have been found in the external module lookup.
/// have been found in the external module lookup.

virtual bool lookupAdditions(Identifier Name, DeclContext *DC,
virtual bool lookupAdditions(DeclBaseName Name, DeclContext *DC,
SourceLoc Loc, bool IsTypeLookup,
ResultVector &RV) = 0;

Expand Down
4 changes: 2 additions & 2 deletions tools/swift-ide-test/swift-ide-test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,13 @@ class NullDebuggerClient : public DebuggerClient {
return false;
}
void didGlobalize(Decl *D) override {}
bool lookupOverrides(Identifier Name, DeclContext *DC,
bool lookupOverrides(DeclBaseName Name, DeclContext *DC,
SourceLoc Loc, bool IsTypeLookup,
ResultVector &RV) override {
return false;
}

bool lookupAdditions(Identifier Name, DeclContext *DC,
bool lookupAdditions(DeclBaseName Name, DeclContext *DC,
SourceLoc Loc, bool IsTypeLookup,
ResultVector &RV) override {
return false;
Expand Down