Remove getName method from ValueDecl #9977
Conversation
|
Please test with following pull request: @swift-ci Please test |
| @@ -400,7 +400,9 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo { | |||
| } | |||
|
|
|||
| SmallVector<char, 64> Buf; | |||
| StringRef Name = (VD->getName().str() + Twine(Kind)).toStringRef(Buf); | |||
| // TODO: Handle special names | |||
There was a problem hiding this comment.
Subscripts can definitely get here, so we'll need to have some way of handling it.
There was a problem hiding this comment.
This is handled in #9979 by calling through to userFacingStr once it exists. That's why I put the TODO there
There was a problem hiding this comment.
Ah, I got the order of patches mixed up. Makes sense.
ahoppen
force-pushed
the
pdm-remove-get-name
branch
from
4252514 to
5c93a0a
Compare
|
Just a rebase onto the new diagnostics commit @swift-ci please test |
ahoppen
force-pushed
the
pdm-remove-get-name
branch
from
5c93a0a to
ece660f
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Push the getName method from ValueDecl down to only those types that are guaranteed to have a name that is backed by an identifier and that will not be special.
ahoppen
force-pushed
the
pdm-remove-get-name
branch
from
ece660f to
2078ec6
Compare
|
@swift-ci Please test and merge |
|
@swift-ci Please test OS X platform |
|
Build failed |
|
We had breakage on master. Should be fixed now... Let's try this again. |
|
Build failed |
|
Build failed |
|
@swift-ci Please test OS X Platform |
Push the getName method from ValueDecl down to only those types that are
guaranteed to have a name that is backed by an identifier and that will
not be special.
This includes the changes from #9975 and #9976