[GSB] *Almost* eliminate the "AlwaysPartial" archetype resolution kind #9981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
When resolving archetypes using the "always partial" resolution kind, we allow the system to form potential archetypes which might be invalid. Start limiting the use of this "always partial" resolution kind, so that it can eventually be removed entirely to simplify the invariants of the GenericSignatureBuilder. Each of the callers should either be working with complete, well-formed archetypes or they should not force any resolution this early.
…traints. Once we're finalizing same-type-to-concrete and superclass constraints, replace any unresolved DependentMemberTypes with their resolved counterpairs. This allows us to simplify DependentGenericTypeResolver, which only builds unresolved DependentMemberTypes now, and eliminates the penultimate use of ArchetypeResolutionKind::AlwaysPartial.
DougGregor
force-pushed
the
gsb-never-always-partial
branch
from
5a73a6e to
a9733cb
Compare
|
@swift-ci please smoke test |
DougGregor
changed the title
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving archetypes using the "always partial" resolution kind,
we allow the system to form potential archetypes which might be
invalid. Start limiting the use of this "always partial" resolution
kind, so that it can eventually be removed entirely to simplify the
invariants of the
GenericSignatureBuilder.Each of the callers should either be working with complete,
well-formed archetypes or they should not force any resolution this
early.
This PR currently limits the use of
ArchetypeResolutionKind::AlwaysPartialto a single place in theGenericSignatureBuilder, which is the point at which we can start delaying resolution.