[ClangImporter] Test for not being in a module correctly. #9992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the Optional<Module *> returned by getClangSubmoduleForDecl, the outside Optional specifies whether there's an answer at all. That answer can still be null if the declaration comes from a bridging header. In this particular case, we're guaranteed to get an answer, but that answer may be null. rdar://problem/32463543
|
@swift-ci Please test |
|
By the way, this only happens in Swift 4 mode. |
|
Build failed |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
Optional<Module *>returned by getClangSubmoduleForDecl, the outside Optional specifies whether there's an answer at all. That answer can still be null if the declaration comes from a bridging header. In this particular case, we're guaranteed to get an answer, but that answer may be null.rdar://problem/32463543