Fixed code style issues reported by python-lint. #9998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed E305 expected 2 blank lines after class or function definition
|
@swift-ci please python lint |
|
@swift-ci Please smoke test and merge |
|
I believe what's going on, is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes coding style issues reported by python-lint, that were introduced in #8610 by @compnerd and #9474 by @graydon
I've done the mistake of forgetting to run
swift/utils/python_lint.pybefore commiting modified python sources, too.How come these "errors" were in the tree for 22 and 21 days, respectively, and didn't break the build? I thought the validation-tests would catch this hard.
@moiseev Please review, test and merge (@ci-swift doesn't listen to me yet...)