-
Notifications
You must be signed in to change notification settings - Fork 50
Change the default install path for macOS pkgs #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default install path for macOS pkgs #259
Conversation
Correct productbuild issue when creating a pkg
@swift-ci test macOS |
@@ -89,22 +89,6 @@ internal struct Init: SwiftlyCommand { | |||
} | |||
} | |||
|
|||
// Ensure swiftly doesn't overwrite any existing executables without getting confirmation first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check had existed to check only if swiftly was already at the destination, prompting before overwriting it. The init subcommand is there to install swiftly, so it's not technically a problem if it's overwriting the binary in the destination. There is a separate check to see if it will be overwriting a user's configuration, and/or toolchains.
…rectory concept into a default swiftlyHomeDirectory
@swift-ci test macOS |
@swift-ci test macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could this change result in a user having two swiftly on path then (if they already had it installed at the previous Library/Application Support
location)?
Yes, but we haven't had an official release of swiftly yet with macOS, so it should be manageable. There is always a general risk that the user could have multiple installs of swiftly in different locations, and we might not be able to easily detect that. One of them will ultimately win in the sense that the env vars override the others at the shell. |
Correct productbuild issue when creating a pkg Set the default swiftly home and binary locations on macOS to ~/.swiftly
Correct productbuild issue when creating a pkg from synthesized
distribution.xml.
Fix quiet option so that it doesn't prevent the environment file from
being added to the profile.