Fix error in extension.test.ts #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
reviewed
Oct 10, 2024
award999
approved these changes
Oct 10, 2024
we should raise a bug for this, the fact we don't get tsc errors when building we cannot let stay. Need to watch for ESLint release so we can upgrade here. Can we temporarily downgrade |
I can raise an issue for this and point it at the relevant issue from TypeScript ESLint.
Our version of TypeScript right now is fine. I just don't want to upgrade us to 5.6.2. This PR also tells VS Code to use the version of TypeScript in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code recently updated its built-in TypeScript Language Server to v5.6.2 which shows an error in
extension.test.tsthat is not present in CI (currently this repo uses TypeScript 5.5.2). However, this is a legitimate issue as therootWorkspaceFoldervariable can indeed be undefined.I've simply fixed up the code in this area to properly handle the fact that the variable can be undefined as well as an issue where a
throwwould not have been handled properly. However, I'm hesitant to jump to TypeScript 5.6.2 since TypeScript ESLint currently does not support 5.6.