Use one launch configuration type for all debug adapters #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
adam-fowler,
0xTim and
award999
as code owners
matthewbastien
requested review from
plemarquand,
award999 and
adam-fowler
and removed request for
adam-fowler,
0xTim and
award999
award999
requested changes
Feb 7, 2025
matthewbastien
force-pushed
the
common-launch-config
branch
from
35267de to
08f8896
Compare
award999
approved these changes
Feb 12, 2025
matthewbastien
added
the
needs verification
matthewbastien
moved this to Needs Verification
in Swift Extension for Visual Studio Code
|
Verified in cef4e6c |
plemarquand
removed
the
needs verification
rbenegal
moved this from Needs Verification
to Done
in Swift Extension for Visual Studio Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of the generated launch configurations to always use a type of
"swift"instead of switching between"swift-lldb"and"lldb"based on user settings. This new launch configuration type will then delegate to the appropriate debug adapter depending on settings. That way the extension no longer has to check for debug configuration updates all the time.I've deprecated the
swift.debugger.useDebuggerFromToolchainsetting in favour of using a newswift.debugger.debugAdaptersetting that is an enumeration of"auto","CodeLLDB", and"lldb-dap". Auto mode will continue to use CodeLLDB by default until we can properly move to the LLDB DAP extension provided by LLVM. Setting this to"lldb-dap"will continue to use the extension provided debug adapter executable factory for the same reason.